diff options
author | John Reck <jreck@google.com> | 2016-02-24 15:36:35 -0800 |
---|---|---|
committer | John Reck <jreck@google.com> | 2016-02-24 15:40:05 -0800 |
commit | f3ad324a8d3f5b5530bd1945f461faf4b0adec8c (patch) | |
tree | a09a5c4f1cb7fc0ede560afb16fdcb92a69035cf /tools/aapt2/java/JavaClassGenerator_test.cpp | |
parent | 8baf238a41099561477d30aa4fef4818c1e8436c (diff) |
Aggressively unbind GL_PIXEL_UNPACK_BUFFER
Bug: 27186019
Theory: It appears to be possible for FontRenderer
to not unbind its PBO prior to textures being uploaded,
resulting in trying to glSubTexImage2D with a bound
GL_PIXEL_UNPACK_BUFFER. In that scenario the void* is
the offset into the PBO which given a non-null data
will almost certainly overrun the end of the buffer. This
in turn produces a GL_INVALID_OPERATION error.
Change PixelBuffer to avoid leaking this state for now.
This will result in more calls to glBindBuffer/glUnbindBuffer
in the worst case, but the worst case is already bad so this
shouldn't be a problem. In the normal case we avoid binding
the PBO at all ever, so this doesn't impact that.
Change-Id: I05473f0d2f9a3a5da0e33d8f9ddea4731ce970e3
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions