summaryrefslogtreecommitdiff
path: root/tools/aapt2/java/JavaClassGenerator_test.cpp
diff options
context:
space:
mode:
authorMady Mellor <madym@google.com>2021-11-17 17:03:23 -0800
committerMady Mellor <madym@google.com>2021-11-24 17:10:34 -0800
commitdbb136d2f57e2fc7ffa2ceea8a1ab80d11e9ca1f (patch)
tree60d46fb32de2928306dc527509e07dcc3a9b900d /tools/aapt2/java/JavaClassGenerator_test.cpp
parent35185d54b4352ac30d587ee42b360d9c46136d10 (diff)
Fix user education placement
We were only showing the user education on click, so you could drag the bubble then click on it, then the user education would appear. However, the bubble wouldn't be in the spot we'd expect due to the initial drag so the user education would be misplaced. This change fixes the issue by showing the user education in the touchlistener onDown(*). Subsequent actions in that gesture won't do anything. A small issue is that the clickListener could be triggered in this state and then immediately hide the education, to work around this I added a flag to indicate if the education showed from the touchListener & skip hiding in that case. (*) Ideally this would occur in a proper down/up action rather than onDown but there's a lot going on in the touch handling and I think this is simplest. Test: manual - (reset device) check that tapping the bubble shows the education - (reset device) check that dragging the bubble shows the education and the bubble doesn't move on the drag - education shouldn't show more than once - bubble should be draggable after the edu goes away Bug: 200151972 Change-Id: I0bdb8d165641b5cad234b3053eb73e0575916102
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions