diff options
| author | Martijn Coenen <maco@google.com> | 2018-07-05 14:58:59 +0200 |
|---|---|---|
| committer | Martijn Coenen <maco@google.com> | 2018-07-09 18:11:18 +0000 |
| commit | d3ef4bf663231b348daed2cd41379853cc6d24c3 (patch) | |
| tree | cf027304c66450d5899b42b16b95589a4ca94221 /tools/aapt2/java/JavaClassGenerator_test.cpp | |
| parent | ce77407144346c6fad679a4297910eea07d0d601 (diff) | |
Move BinderProxy serialization into Java.
The BinderProxy class is not thread-safe, and all calls into
it were serialized by holding gProxyLock from JNI code. More
recently, we've been wanting to access BinderProxy from Java
code directly, and having the lock in native complicated things.
This change removes the lock in native code and adds it in the
Java layer. A benefit of this change is that it reduces the
scope of where a lock is held. On the flip side, we no longer
have a cached BinderProxyNativeData object lying around. This
means we now allocate/free a BinderProxyNativeData even if we
already have a Java object lying around for the native object,
which can happen quite frequently. But we deem the impact of
this to be acceptable.
Bug: 109888955
Test: sailfish builds, boots, proxy warnings still show
Change-Id: If2f4dbe5486ec7af0ef8ea42d24ac3a4330cc05a
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions