summaryrefslogtreecommitdiff
path: root/tools/aapt2/java/JavaClassGenerator_test.cpp
diff options
context:
space:
mode:
authorDa Xing <qiyueliuhuo813@gmail.com>2018-11-18 20:10:17 +0800
committerJulia Reynolds <juliacr@google.com>2019-08-20 12:03:35 -0400
commitb740ed72b93e4671ced674456b2eaac26fda5ab9 (patch)
treebf8cbd9ec50003ddfefa6d725936ab5f131ee19e /tools/aapt2/java/JavaClassGenerator_test.cpp
parent95dbff5e7817b1b7e36c7d518b4818be5c23dc32 (diff)
Crash app on foreground service notification error.
On any notification error, the NMS silently cancels the notification, including foreground service notifications. Thus, an app could pass in a garbage notification deliberately and start a foreground service silently. This patch resolved this issue by judging the notification's flag, and if it is a foreground notification, still crash the app as previous platforms, and if it is a normal notification, don't crash the app. Background: In 3ad4cdd1, which was merged into Android 9 release, the crash behaviour is removed. But it is an important rule that foreground services guaranteed to show an ongoing notification. Test: Run the sample apk provided in the issue, it's main thread received a RemoteServiceException: Bad notification posted from package... as intended behaviour. Fixes: 118612296 Change-Id: I36ea0137ca6978ff401f64dccacb6f2edcadd7db Signed-off-by: Da Xing <qiyueliuhuo813@gmail.com>
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions