diff options
| author | Geoffrey Pitsch <gpitsch@google.com> | 2016-08-24 10:37:19 -0400 |
|---|---|---|
| committer | Geoffrey Pitsch <gpitsch@google.com> | 2016-08-24 17:20:36 -0400 |
| commit | b2d6ed3cd125d616ab44b89e36af34a52756c47c (patch) | |
| tree | 151919f88ec43ac57de585313fe58207aef80f46 /tools/aapt2/java/JavaClassGenerator_test.cpp | |
| parent | edaaef304aa7e72ac3f8a0b586b5513fd4df0267 (diff) | |
Prevent notifyScreenshotError() from calling twice
Found this while investigating the attached bug.
Fixes potential race condition between onServiceDisconnected and
mScreenshotTimeout both calling notifyScreenshotError.
If onServiceDisconnected is going to show an error to the user, I think
it should also unbind, as we would expect the user to re-take the shot
at that point. Ideally, this would replace the timeout handler entirely.
Not exactly sure how to test this - I tried crashing the
TakeScreenshotService locally, but onServiceDisconnected didn't trigger.
Bug: 28982719
Change-Id: I5093c61735b0661f9874c686e197cd894c3ef7ae
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions