summaryrefslogtreecommitdiff
path: root/tools/aapt2/java/JavaClassGenerator_test.cpp
diff options
context:
space:
mode:
authorRobert Carr <racarr@google.com>2020-06-26 11:31:19 -0700
committerRob Carr <racarr@google.com>2020-06-26 18:47:28 +0000
commit9a808a2ee29e72d1b39e4af94e5e45aaa209f459 (patch)
tree6891fc2ede2b4098897cc58017148da649e83199 /tools/aapt2/java/JavaClassGenerator_test.cpp
parent2ba2ce12823b736a5b7088a8fa7401dc8ee0d21b (diff)
SurfaceView: Clean up deferred-destroy-surface from UI thread
We utilize mTmpTransaction without locking from the main thread. The callback info inside the transaction stores an sp to the SurfaceControl. If we apply the Transaction from two threads independently we may implicitly call reset() on the same sp instance twice in an overlapping fashion. While the reference count is itself atomic, that wont stop us from decrementing it twice here, when we only had one reference. This leads to an early free and a crash later. Bug: 159333209 Test: Existing tests pass Change-Id: I898bef0b6b8c1cf34891410bbadf63fe2f840697
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions