diff options
| author | Mihai Popa <popam@google.com> | 2018-04-16 14:27:05 +0100 |
|---|---|---|
| committer | Mihai Popa <popam@google.com> | 2018-04-26 10:58:31 +0100 |
| commit | 819e90d3f6b8296e367f753b141861351ea7f50f (patch) | |
| tree | 384664db802d1066c93373232f50751d3a88f73a /tools/aapt2/java/JavaClassGenerator_test.cpp | |
| parent | a7579d632590457cb987f0199550ab4e25fb504d (diff) | |
[Magnifier-40] Always child of main window
Previously, we were making the magnifier surface a child of the main
window unless the magnified view was a SurfaceView, in which case we
were setting the SurfaceView to be the parent of the magnifier. In
Chrome, where the magnified views are usually SurfaceViews, this caused
the magnifier to be displayed underneath the omnibox, which was a
terrible user experience when trying to magnify the first lines of text
on a page. This was because the omnibox had a higher Z than the
SurfaceView, and therefore a higher Z than all children of the
SurfaceView (including the magnifier).
This CL sets the parent of the magnifier surface to be the main window's
surface when the magnified view is a SurfaceView as well. Therefore, the
magnifier becomes a sibling of the Chrome omnibox and, by giving the
magnifier a higher Z, it ends up being rendered on top.
Bug: 77926365
Test: atest CtsWidgetTestCases:android.widget.cts.MagnifierTest
Change-Id: Ic5b5f6ca687db8b5d842f0ab20eac70f1fd2f85e
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions