diff options
| author | Yohei Yukawa <yukawa@google.com> | 2020-04-09 22:38:04 -0700 |
|---|---|---|
| committer | Yohei Yukawa <yukawa@google.com> | 2020-04-09 22:38:04 -0700 |
| commit | 7029cc3da8d8b675abd92579aa7f04b50ad6d291 (patch) | |
| tree | a3cc4c423636282747b8dc962d66a87e72839684 /tools/aapt2/java/JavaClassGenerator_test.cpp | |
| parent | e6897b195079143665b5005771fec88e8076515f (diff) | |
Add an empty IMM#windowDismissed(IBinder) for app compat
It seems that there are several applications that call
InputMethodManager#windowDismissed(IBinder), which was recently
removed [1], then crash due to unhandled NoSuchMethodException
exception.
The most probable hypothesis that explains why these apps ended up
calling this method via reflection is trying to address object leaks
from InputMethodManager, which we have received reports then fixed all
the known issues [2][3][4][5][6]. There are several Internet articles
that claim calling InputMethodManager#windowDismissed(IBinder) can
*fix* such object leaks, which is in fact no longer necessary in
recent versions of Android. However, it seems that some of such apps
didn't gracefully take care of cases where IMM#windowDismissed()
doesn't exist then ended up crashing due to unhandled
NoSuchMethodException.
Note also that AndroidX Activity (androidx.activity.ComponentActivity)
already implements a similar workaround [7] hence app developers no
longer need to work around by themselves.
Anyways, in order to avoid unnecessary crashes from apps that call
IMM#windowDismissed() via reflection, this CL re-introduce it as an
empty method. As their goal is supposed to be clearing internal
fields within InputMethodManager to avoid object leaks, an empty
method is believed to be sufficient.
[1]: Ib455704fe1e9d243f93190a84f230210dbceac2a
970d9d2e0c979cf9a0ff0a79ef49044ed1363d4f
[2]: Iad09cf5dbb7f6f156fd39ed243431432e00f8945
4478de3c02c1fb2f4f888e696ee1b13721e936d9
[3]: Iaf3fe2c065b5bf91e49a729ba46262114bb6da88
b13f015ab519b3e553c03eba971ada89b472fbbc
[4]: I219394178e4172bc47864297f1418e677dba25e5
5f05965f546fa42750f1a8314f8a2da01fd6bfb4
[5]: Id6afc8fc64512225578c62557b96c7dc2e969adf
0f3a99d837048ae82855c2306cd454426393c19f
[6]: I8fabb30f14bcb2cd7019e29b6642b4562d49d248
dff365ef4dc61239fac70953b631e92972a9f41f
[7]: I615e92f0c64b6d668b31f2c83527b7409a7bef6f
b1bf8502e0574a4bfcf450235595372b7cb3778a
Fix: 152261618
Test: manually verified with apps in question
Change-Id: I599896a96267fc60a738eac31be02b770e10dff3
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions