diff options
| author | Mihai Popa <popam@google.com> | 2018-05-08 19:18:43 +0100 |
|---|---|---|
| committer | Mihai Popa <popam@google.com> | 2018-05-22 10:42:16 +0100 |
| commit | 6748ff37db680fbe832a977377540e9a03a0d4c7 (patch) | |
| tree | 52db4696d41d7ed0f9ad4c2efab84e198a4495b3 /tools/aapt2/java/JavaClassGenerator_test.cpp | |
| parent | 677ffbc40bba7fccd913196b459c4e0bf09193fe (diff) | |
Fix crash after smart selection animation
At the end of the smart selection animation, we run a callback that sets
the selection on the TextView (subsequently starting the action mode
toolbar and showing the handles). However, when the text changes before
the animation finishes, the selection might not be valid, and might get
out of the text bounds, which was producing a crash. This was observed
in a monkey crash. This CL fixes this bug by refusing to set the
selection when it goes outside the text bounds, corresponding to the
case when text has changed between the time the animation has started
and the time it ended.
Bug: 69919777
Test: manual testing before and after the fix
Change-Id: Iea043f320004d45ad16dd7e9e5b47e5256e6d9fa
(cherry picked from commit cce6e82d35b5a6c8eb29e76fbae53eae8b70e99a)
Merged-in: Iea043f320004d45ad16dd7e9e5b47e5256e6d9fa
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions