diff options
| author | Lyn Han <lynhan@google.com> | 2019-08-23 17:06:56 -0700 |
|---|---|---|
| committer | Lyn Han <lynhan@google.com> | 2019-10-30 14:10:44 -0700 |
| commit | 58a55222835400b8d8ac1ca9eda69f943bb4b97c (patch) | |
| tree | 59bf992c8040b8d0494b27948b423d5625b989e0 /tools/aapt2/java/JavaClassGenerator_test.cpp | |
| parent | 39195ba2113235953e01a57b33508bc9519cbe0c (diff) | |
Fix dot for smart reply and bubble groups [DO NOT MERGE]
[Cherrypicked from master]
Android Messages sends two notifications per message
- New notif
- Smart reply update
This change fixes
- dot bugs that occur when two notifications arrive in quick succession for the same bubble
- regressions for bubble groups
BubbleStackView
- clearFlyoutOnHide: enforce flyout onHide to run once for the bubble it was updated for
- refactors for clarity
BubbleView
- shouldShowDot: refactor show-dot logic into function
updateViews did not account for mSuppressDot
=> dot flashed into view before being animated away by later dot visibility updates
- updateDotVisibility: add missing call to setDotScale if animate=false
Fixes: 138659213
Test: add bubble group with test app
expand bubbles => update dots show for non-expanded bubbles
expand bubbles, click through bubbles => dots go away
expand bubbles, dismiss single bubble => summary (with one less notif) stays in scrim
Test: add mixed bubble group with test app
expand bubbles, dismiss all bubbles => scrim notif for non-bubbling group stays
Bug: 138755533
Test: send android messages sms => flyout and dot behave as expected
Test: create bubble with test app => flyout and dot behave as expected
Test: atest SystemUITests
Change-Id: Ieb2e6c306a0b55aec248bd1582246b67eafab290
(cherry picked from commit f1f2c33f2c2d31d174779252005682b5f17126cd)
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions