diff options
| author | Nathan Harold <nharold@google.com> | 2020-02-13 19:50:51 -0800 |
|---|---|---|
| committer | Nathan Harold <nharold@google.com> | 2020-02-13 19:57:59 -0800 |
| commit | 5522de1af3bd875cfb4aa584e275ff148e95eb1f (patch) | |
| tree | efcd1fbbd9eff63decdd3c5e9d1ac3316cad9aa9 /tools/aapt2/java/JavaClassGenerator_test.cpp | |
| parent | 2fb0bc50f93a728c52dd729ba28005ba1061b2b3 (diff) | |
Convert getAdditionalPlmns to return a Set
Set support is a little weird in Java and Android.
Java doesn't support ArraySet, but Android does; Parcel
has both read/write for ArraySet, but they are @hide. Thus,
my options were limited to:
-use the hidden parcel methods
-convert between list and set in the constructor and parcel code
-convert between list and set in the getter
-maintain parallel data structures.
Using the hidden methods seemed cleanest. Since they are
@UnsupportedAppUsage they can't be credibly removed.
In addition, the HAL code doesn't understand Set<> only List<> so
I was faced with the choice of having 2 constructors or using
Collection<>, which actually works just fine and avoids changing
a hundred or so unit tests with no ill effect.
Bug: 149476549
Test: atest FrameworksTelephonyTests
Test: (cts) atest CellInfoTest
Change-Id: I9dfa5f59512f3d1305187cc383c4069ceaaf27fd
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions