diff options
| author | Michal Brzezinski <brzezinski@google.com> | 2021-10-25 18:35:27 +0200 |
|---|---|---|
| committer | Michal Brzezinski <brzezinski@google.com> | 2021-10-28 16:40:21 +0100 |
| commit | 54279e44b2f76658706320c6e982b6284fde14f1 (patch) | |
| tree | 0fb2c75a72749058b5e5b9d1bfe564692638f198 /tools/aapt2/java/JavaClassGenerator_test.cpp | |
| parent | 2a482869f7507f8ede43ba09894959096b62e5c8 (diff) | |
Fixing brightness slider jank in split shade
This jank was caused by two sliders - one in QS and one in QQS - being updated at the same time.
When sliding one, the other one register changes in brightness and is trying to animate itself into the new value. Because they share one mirror, seems like mirror is getting conflicting signals about current values - one mirror animates, the other doesn't.
Another issue this fixes is changing brightness significantly and quickly switching to collapsed or expanded QS - the animation would not end till new slider shows up and slider would be moving, even though the other slider was not moving.
Also renaming BrightnessSlider to BrightnessSliderController (because it seems to be naming convention for controllers) - that makes this change so wide-reaching.
Fixes: 196523321
Test: open split shade -> slide finger (not tap) on top of slider to change brightness -> lift finger and see no jank
Change-Id: Ie11e3670f1464e5f1c85e221ce09b6ebf6dd4d0c
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions