diff options
| author | Jordan Demeulenaere <jdemeulenaere@google.com> | 2021-10-07 15:22:19 +0200 |
|---|---|---|
| committer | Jordan Demeulenaere <jdemeulenaere@google.com> | 2021-10-08 13:54:10 +0200 |
| commit | 4cd6a2ad2db15ff6d5cc4dd030d30c30460df6a0 (patch) | |
| tree | e17db999fc5578c0a287d2bd5b145efb4f46fffa /tools/aapt2/java/JavaClassGenerator_test.cpp | |
| parent | 97a5f472ccf8ae9f65e630f102de5995c5d2f01c (diff) | |
Fix SysUI crash when locking while showing the Media Output Group dialog
This CL fixes a bug introduced by http://ag/15663086: When locking the
phone while showing the Media Output Group dialog, SystemUI would crash
because of a mismatch between MediaOutputAdapter.currentActivePosition
and MediaOutputController.mMediaDevices. That mismatch came from the
sharing of the controller between the 2 dialogs, that are now shown at
the same time (even though one is hidden).
Starting from this CL, both dialogs now use a separate instance of
MediaOutputController to avoid this kind of race condition. This CL also
adds a safeguard in MediaOutputBaseDialog to ensure that we notify an
item change within bounds, which would otherwise throw and crash.
Bug: 200781817
Test: Show media output group dialog then lock phone.
Change-Id: I7749cc963a5e145467b32aa3a9efb1e80009f324
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions