summaryrefslogtreecommitdiff
path: root/tools/aapt2/java/JavaClassGenerator_test.cpp
diff options
context:
space:
mode:
authorDan Sandler <dsandler@android.com>2015-05-19 20:59:12 -0400
committerDan Sandler <dsandler@android.com>2015-05-20 10:00:54 -0400
commit3936e7a6fb6ab5a3ee4bfa7e54786f0ee103d4bb (patch)
tree0a1fccbbe5d3349e529da5bd78850861ef335db4 /tools/aapt2/java/JavaClassGenerator_test.cpp
parent77b01b887670b01f543558cd5cfd7d5d228d6c21 (diff)
Deal more gracefully with null smallIcons.
First, when parceling a notification with no small icon: Well, you shouldn't attempt to do this anyway, since NoMan will reject a notification without a valid smallIcon. But setServiceForeground parcels up the Notification on its own before handing it off to NoMan, so it will crash on an invalid small icon. (In general, parceling code should never ever crash, even if the object is in an undesirable state.) And when build()ing a notification: Same thing---don't build a notification with no icon; you're going to have a bad time. But maybe you're going to fix it before you hand it off to NoMan. Or maybe it's just one page of a wearable notification, so it doesn't really need its own icon. Either way, Notification shouldn't crash. Bug: 21286186 Bug: 21298403 Change-Id: Ie482cde0a3afe3aaabf07be0536551b8e4bceba0
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions