diff options
| author | Hyangseok Chae <neo.chae@lge.com> | 2019-11-08 08:01:39 +0900 |
|---|---|---|
| committer | Julia Reynolds <juliacr@google.com> | 2019-11-11 14:09:42 +0000 |
| commit | 1d9b8054097558cfe72d53f43371145d1d87d137 (patch) | |
| tree | 26004208e197affa3ad8c49356d21f4b0d0ebb86 /tools/aapt2/java/JavaClassGenerator_test.cpp | |
| parent | 5fdaa0c9af03cf5199bc6d6bb630d4c18f5bce05 (diff) | |
Fix a missing synchronization to Notification
Concurrent access on allPendingIntents could cause
crash by ArrayIndexOutOfBoundsException.
Below two accesses can occur in two different threads.
But allPendingIntents(ArraySet) is not thread-safe.
1. Access to write.
allPendingIntents = new ArraySet<>();
parcel.writeArraySet(allPendingIntents)
2. Access to add.
allPendingIntents.add(intent);
So, we added missing synchronization to Notification
Test:
It is hard to reproduce by manual.
Make/Update notification with pendingintent.
Change-Id: Ib866f6b92528f7a944ac93997a9cff07892d4192
Bugs: 144081764
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator_test.cpp')
0 files changed, 0 insertions, 0 deletions