diff options
| author | Lorenzo Colitti <lorenzo@google.com> | 2017-08-14 13:07:42 +0900 |
|---|---|---|
| committer | Lorenzo Colitti <lorenzo@google.com> | 2017-08-15 12:02:33 +0900 |
| commit | dca784af3c30bd077483d37001b8528b9d9ee490 (patch) | |
| tree | f903f89bd49c3314aa34ed0c70c5a80c989c4fcd /tools/aapt2/java/JavaClassGenerator.cpp | |
| parent | 27ad3f1e48c615a9e47f6ce4ef4d1f5b79ac9e98 (diff) | |
Don't time out when fetching tether offload stats.
Currently, fetching tethering offload stats has a 1000ms timeout,
after which we return stats of zero. However, returning zero is
invalid and will cause various parts of the network stats
accounting code to complain that statistics are moving backwards,
causing at least a log.wtf, and possibly a crash.
This CL removes the timeout entirely.
An alternative would have been to keep the timeout and return
null if the stats fetch failed. However, this complicates the
code, and if the HAL is persistently slow, could cause no stats
to be counted, ever. Given the impact of such behaviour on users'
data plans it is likely better to block until the stats are
collected.
(cherry picked from commit fef69a126793c83aa0d99a8c597037c3a29929c0)
Bug: 29337859
Bug: 32163131
Test: builds
Test: OffloadControllerTest passes
Change-Id: I1e017b6fef2d8a02a7edbf35bed3e4402f447ab9
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator.cpp')
0 files changed, 0 insertions, 0 deletions