summaryrefslogtreecommitdiff
path: root/tools/aapt2/java/JavaClassGenerator.cpp
diff options
context:
space:
mode:
authorFilip Gruszczynski <gruszczy@google.com>2015-03-23 12:59:02 -0700
committerFilip Gruszczynski <gruszczy@google.com>2015-03-23 13:08:56 -0700
commitd66ba06a8727fa27d1f4bcb867be17b5f576384c (patch)
tree73f6dd9ac7b0ea9beb154f1ca2c0faac50be8bb7 /tools/aapt2/java/JavaClassGenerator.cpp
parenteded9424305cb6538cc0516670930a9f8fccbfd1 (diff)
Don't use windowOutsetBottom for insets, depend on display padding only.
I am not sure if this is the correct approach to the problem. Right now we are reporting double chin (60 vs 30). The reason for this is that we setDisplayPadding from Clockwork Home activity (bottom=30) and add windowOutsetBottom. We use display padding to set surface frame size (320x320) and both outset bottom and display padding for inset. I think we should use only one of these. I decided to go with display padding, because that's what was suggested to me the last time I visited this. I removed the dependency on windowOutsetBottom altogether. However, I don't feel confident this is the correct way to do this. We depend on Home activity to send the display padding now to get the correct result, so wallpapers behind other activities will not work correctly. Maybe instead of setting display padding from the outside, the windowOutsetBottom should be added to display padding bottom for the purpose of calculating surface frame and generating insets. Advice on what is the right approach here would be greatly appreciated. Bug: 19881056 Change-Id: Ifb655528d8f85ef01d942bf1e64e8b08475689ca
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator.cpp')
0 files changed, 0 insertions, 0 deletions