diff options
| author | Hugo Benichi <hugobenichi@google.com> | 2017-05-22 10:44:02 +0900 |
|---|---|---|
| committer | Hugo Benichi <hugobenichi@google.com> | 2017-05-23 10:18:41 +0900 |
| commit | bb91c57ec5226f11a12653dd988c30b7e3d07ae8 (patch) | |
| tree | 62dd8f47305d28184bad3065fff69ba187e70fff /tools/aapt2/java/JavaClassGenerator.cpp | |
| parent | 70fe11fc38c6b40a5e183ee1dcb18134164a7c35 (diff) | |
ConnectivityServiceTest: fix flakyness
This patch attempts to fix the remaining spurious failures in
ConnectivityServiceTest, which have two causes:
- waitForIdle() does not take into account the NetworkAgents handlers.
- the deadlines in testRequestBenchmark are sometimes exceeded.
To fix the first issue, waitForIdle() is moved to a test level instance
method and also calls waitForIdleHandler on any non null
MockNetworkAgent. This is expected to fix spurious errors for the
following tests:
- testMobildeDataAlwaysOn
- testLingering
- testPacketKeepAlive
- testMMSonWiFi
To fix the second issue, the deadlines for testRequestBenchmark are
extended by 10ms. Also, the failure message is made more actionable by
providing the total time it took for the operation, instead of printing
the number of dispatches that were achieved before the deadline.
Bug: 32561414
Test: tests pass many times in a row (~500).
Change-Id: Id33c6ac1edfb0b89634fa7789dccb2da237e2709
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator.cpp')
0 files changed, 0 insertions, 0 deletions