diff options
| author | Lyn Han <lynhan@google.com> | 2022-02-08 12:36:02 -0600 |
|---|---|---|
| committer | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2022-02-14 23:13:00 +0000 |
| commit | a8535e9ae6d86ffbc5ec717f849321345de585e3 (patch) | |
| tree | e4f7271fe22cfce368164b1cc08aca4cd98eab2f /tools/aapt2/java/JavaClassGenerator.cpp | |
| parent | c3ea2d31568121d012a0da7cbe8260f1304ca19f (diff) | |
Fix bug where shade is infinitely squishy after wallpaper change
This change fixes a bug where
opening an empty shade after wallpaper update
=> messes up qs button unfurling
=> hides the "no notifications" text
This bug happened because
=> wallpaper change causes theme change
=> on theme change, NSSLC reinflates EmptyShadeView
with visibility=false
=> nothing resets EmptyShadeView visiblity=true on shade open
=> AmbientState has 0 visibleChildren during shade open,
so stackHeight is 0 and expansionFraction is infinity
The solution is to have NSSLC
update EmptyShadeView visibility after re-inflation.
Fixes: 215038354
Fixes: 218501868
Fixes: 218380326
Test: have no notifications, change wallpaper, open shade
=> qs button squishiness animates fine
=> "no notifications" text shows up fine
=> log squishiness: no infinity or NaN
Change-Id: Iaa10605079db7edc79771a1cd9f4cc17f847c4cb
(cherry picked from commit d2adae5b5d8a1b6a77386cc7eaf98dafe4b43ce4)
(cherry picked from commit cf293657bf6520ea04f0c5eab493ad06f1f472f5)
Merged-In:Iaa10605079db7edc79771a1cd9f4cc17f847c4cb
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator.cpp')
0 files changed, 0 insertions, 0 deletions