summaryrefslogtreecommitdiff
path: root/tools/aapt2/java/JavaClassGenerator.cpp
diff options
context:
space:
mode:
authorEran Messeri <eranm@google.com>2018-06-28 11:20:44 +0100
committerEran Messeri <eranm@google.com>2018-06-28 17:20:01 +0100
commit5a5c6e0e44fbccbf5608c1955debf1650890f5a6 (patch)
tree70d9eebea919172b9898bcdf0fe4e594d28d36ed /tools/aapt2/java/JavaClassGenerator.cpp
parent143c65d520b197a271d6de282fc7759d8009ce44 (diff)
Correctly preserve key generation parameters
Due to an oversight, some of the key generation parameters that are set in KeyGenParameterSpec were not preserved when parceling the object (they should have been added to ParcelableKeyGenParameterSpec but were not). This means these parameters will be ignored when generating keys using the DevicePolicyManager.generateKeyPair method, leading to an inconsistent key generation behaviour between the DevicePolicyManager and KeyStore. In particular, this would prevent callers from using StrongBox when generating keys for use in the KeyChain. Fix the issue by simply persisting these parameters in ParcelableKeyGenParameterSpec and making sure that the Builder copies them too from the source KeyGenParameterSpec. Left to do is put in place an automated measure to find out discrepancies between the two classes. Bug: 110915980 Bug: 110882855 Bug: 109953656 Test: atest KeystoreTests Change-Id: Ic64bd2921b6dfc97ea34ecba55f532312963ffcb
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator.cpp')
0 files changed, 0 insertions, 0 deletions