diff options
| author | Niklas Brunlid <niklas.brunlid@sony.com> | 2017-11-02 09:26:37 +0100 |
|---|---|---|
| committer | Henrik Baard <henrik.baard@sony.com> | 2017-11-14 10:17:56 +0100 |
| commit | 2ecbe69ddd4fc93e83c2810ab88abb03e4f9f718 (patch) | |
| tree | ff5c02a3877e79f01d527dbf898ef599be84969b /tools/aapt2/java/JavaClassGenerator.cpp | |
| parent | f7f5732e2c33677ef701194f5051805762e99fe8 (diff) | |
Avoid overflow in focus fudge calculation
When comparing decoding the next View to get focus, the last-resort
calculation (magic number and square of distance between the View
corners) could overflow, giving a false positive. This causes the
focus to jump around in certain cases. Change from int to long to
avoid in the foreseeable future.
Test: Manual
- Use a phone with an 18:9 ratio (1080*2160)
- make FrameworksCoreTests
- adb install -r out/target/product/aurora/data/app/FrameworksCoreTests/FrameworksCoreTests.apk
- adb shell am instrument -r -w -e class android.widget.scroll.ScrollViewButtonsAndLabelsTest#testArrowScrollUpOffScreenVerticalFadingEdge com.android.frameworks.coretests/android.support.test.runner.AndroidJUnitRunner
Change-Id: I119cd66f563cfa312c2304bb910c27075e674e59
Diffstat (limited to 'tools/aapt2/java/JavaClassGenerator.cpp')
0 files changed, 0 insertions, 0 deletions