diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2016-08-10 14:15:30 -0700 |
|---|---|---|
| committer | Chih-Hung Hsieh <chh@google.com> | 2016-08-11 15:16:41 -0700 |
| commit | 9b8528fee4eed35b8e887ded0851d08eb2b10db6 (patch) | |
| tree | 36df1cee89b3689454e6b09a6bfa5eabfb3214b1 /tools/aapt2/StringPool.h | |
| parent | 7310353aeb771c109e5aea2c5415fa502eb13a7b (diff) | |
Fix clang-tidy warnings in aapt and aapt2.
* Add explicit keyword to conversion constructors.
* Add NOLINT(implicit) comments for implicit conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters.
Bug: 30407689
* Use const reference type to avoid unnecessary copy.
Bug: 30413862
Test: build with WITH_TIDY=1
Change-Id: Id6d21961f313a1ad92b15a37fdaa5be9e8ab48e1
Diffstat (limited to 'tools/aapt2/StringPool.h')
| -rw-r--r-- | tools/aapt2/StringPool.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/aapt2/StringPool.h b/tools/aapt2/StringPool.h index 72ae9d184a78..13545bef53ab 100644 --- a/tools/aapt2/StringPool.h +++ b/tools/aapt2/StringPool.h @@ -65,7 +65,7 @@ public: private: friend class StringPool; - Ref(Entry* entry); + explicit Ref(Entry* entry); Entry* mEntry; }; @@ -88,7 +88,7 @@ public: private: friend class StringPool; - StyleRef(StyleEntry* entry); + explicit StyleRef(StyleEntry* entry); StyleEntry* mEntry; }; |