diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2016-08-10 14:15:30 -0700 |
|---|---|---|
| committer | Chih-Hung Hsieh <chh@google.com> | 2016-08-11 15:16:41 -0700 |
| commit | 9b8528fee4eed35b8e887ded0851d08eb2b10db6 (patch) | |
| tree | 36df1cee89b3689454e6b09a6bfa5eabfb3214b1 /tools/aapt2/ResourceUtils.cpp | |
| parent | 7310353aeb771c109e5aea2c5415fa502eb13a7b (diff) | |
Fix clang-tidy warnings in aapt and aapt2.
* Add explicit keyword to conversion constructors.
* Add NOLINT(implicit) comments for implicit conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters.
Bug: 30407689
* Use const reference type to avoid unnecessary copy.
Bug: 30413862
Test: build with WITH_TIDY=1
Change-Id: Id6d21961f313a1ad92b15a37fdaa5be9e8ab48e1
Diffstat (limited to 'tools/aapt2/ResourceUtils.cpp')
| -rw-r--r-- | tools/aapt2/ResourceUtils.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/aapt2/ResourceUtils.cpp b/tools/aapt2/ResourceUtils.cpp index 7dc88dedc96e..773616d6aa71 100644 --- a/tools/aapt2/ResourceUtils.cpp +++ b/tools/aapt2/ResourceUtils.cpp @@ -545,7 +545,7 @@ uint32_t androidTypeToAttributeTypeMask(uint16_t type) { std::unique_ptr<Item> parseItemForAttribute( const StringPiece& value, uint32_t typeMask, - std::function<void(const ResourceName&)> onCreateReference) { + const std::function<void(const ResourceName&)>& onCreateReference) { std::unique_ptr<BinaryPrimitive> nullOrEmpty = tryParseNullOrEmpty(value); if (nullOrEmpty) { return std::move(nullOrEmpty); @@ -604,7 +604,7 @@ std::unique_ptr<Item> parseItemForAttribute( */ std::unique_ptr<Item> parseItemForAttribute( const StringPiece& str, const Attribute* attr, - std::function<void(const ResourceName&)> onCreateReference) { + const std::function<void(const ResourceName&)>& onCreateReference) { const uint32_t typeMask = attr->typeMask; std::unique_ptr<Item> value = parseItemForAttribute(str, typeMask, onCreateReference); if (value) { |