diff options
author | Chih-Hung Hsieh <chh@google.com> | 2017-08-03 16:28:10 -0700 |
---|---|---|
committer | Chih-Hung Hsieh <chh@google.com> | 2017-08-03 16:28:10 -0700 |
commit | 4dc5812dc065df9ce7427fdb270120cdf44025c3 (patch) | |
tree | a4e4c495dc800d3a6fab0fe86e558a86eada6a19 /tools/aapt2/LoadedApk.cpp | |
parent | d02180fa204347407c45ff0dbb93a878a663fc08 (diff) |
Fix clang-tidy performance warnings in aapt2.
* Use const reference parameter type to avoid unnecessary copy.
* Use more efficient overloaded string methods.
Bug: 30407689
Bug: 30411878
Test: build with WITH_TIDY=1
Change-Id: Iaa0a6f18f64cf573bee49dd1466281ea4d37b410
Diffstat (limited to 'tools/aapt2/LoadedApk.cpp')
-rw-r--r-- | tools/aapt2/LoadedApk.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/aapt2/LoadedApk.cpp b/tools/aapt2/LoadedApk.cpp index 7e5efa15f61b..abc0e4c1b89d 100644 --- a/tools/aapt2/LoadedApk.cpp +++ b/tools/aapt2/LoadedApk.cpp @@ -84,7 +84,7 @@ bool LoadedApk::WriteToArchive(IAaptContext* context, const TableFlattenerOption std::string path = file->GetSource().path; // The name of the path has the format "<zip-file-name>@<path-to-file>". - path = path.substr(path.find("@") + 1); + path = path.substr(path.find('@') + 1); // Skip resources that are not referenced if requested. if (path.find("res/") == 0 && referenced_resources.find(path) == referenced_resources.end()) { |