diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2016-08-10 14:15:30 -0700 |
|---|---|---|
| committer | Chih-Hung Hsieh <chh@google.com> | 2016-08-11 15:20:10 -0700 |
| commit | 8bd37ba458633ee7b2aeec0a7593817000aa84b2 (patch) | |
| tree | 35336b2eadacdeeed7ed64b3bce40cf008a97197 /tools/aapt/StringPool.h | |
| parent | d0197ac3402e5d85324db4230407115ddec8011a (diff) | |
Fix clang-tidy warnings in aapt and aapt2.
* Add explicit keyword to conversion constructors.
* Add NOLINT(implicit) comments for implicit conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters.
Bug: 30407689
* Use const reference type to avoid unnecessary copy.
Bug: 30413862
Test: build with WITH_TIDY=1
Change-Id: Id6d21961f313a1ad92b15a37fdaa5be9e8ab48e1
Merged-In: Id6d21961f313a1ad92b15a37fdaa5be9e8ab48e1
Diffstat (limited to 'tools/aapt/StringPool.h')
| -rw-r--r-- | tools/aapt/StringPool.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/aapt/StringPool.h b/tools/aapt/StringPool.h index 4b0d920c3274..625b0bfb3832 100644 --- a/tools/aapt/StringPool.h +++ b/tools/aapt/StringPool.h @@ -41,7 +41,7 @@ class StringPool public: struct entry { entry() : offset(0) { } - entry(const String16& _value) : value(_value), offset(0), hasStyles(false) { } + explicit entry(const String16& _value) : value(_value), offset(0), hasStyles(false) { } entry(const entry& o) : value(o.value), offset(o.offset), hasStyles(o.hasStyles), indices(o.indices), configTypeName(o.configTypeName), configs(o.configs) { } |