diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2016-08-10 14:15:30 -0700 |
|---|---|---|
| committer | Chih-Hung Hsieh <chh@google.com> | 2016-08-11 15:16:41 -0700 |
| commit | 9b8528fee4eed35b8e887ded0851d08eb2b10db6 (patch) | |
| tree | 36df1cee89b3689454e6b09a6bfa5eabfb3214b1 /tools/aapt/CrunchCache.cpp | |
| parent | 7310353aeb771c109e5aea2c5415fa502eb13a7b (diff) | |
Fix clang-tidy warnings in aapt and aapt2.
* Add explicit keyword to conversion constructors.
* Add NOLINT(implicit) comments for implicit conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters.
Bug: 30407689
* Use const reference type to avoid unnecessary copy.
Bug: 30413862
Test: build with WITH_TIDY=1
Change-Id: Id6d21961f313a1ad92b15a37fdaa5be9e8ab48e1
Diffstat (limited to 'tools/aapt/CrunchCache.cpp')
| -rw-r--r-- | tools/aapt/CrunchCache.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/aapt/CrunchCache.cpp b/tools/aapt/CrunchCache.cpp index 0d574cf127dd..7b8a576b88d3 100644 --- a/tools/aapt/CrunchCache.cpp +++ b/tools/aapt/CrunchCache.cpp @@ -94,7 +94,7 @@ void CrunchCache::loadFiles() delete dw; } -bool CrunchCache::needsUpdating(String8 relativePath) const +bool CrunchCache::needsUpdating(const String8& relativePath) const { // Retrieve modification dates for this file entry under the source and // cache directory trees. The vectors will return a modification date of 0 |