summaryrefslogtreecommitdiff
path: root/tests/DynamicCodeLoggerIntegrationTests/src/cpp/test_executable.cpp
diff options
context:
space:
mode:
authorAhaan Ugale <augale@google.com>2020-04-17 21:38:47 -0700
committerAhaan Ugale <augale@google.com>2020-04-18 15:51:58 -0700
commite763059a29c4b637ca926cbe69d54432f6910d83 (patch)
tree657cd10075d7ccd7e7b2f7585fbbd2ec1b3693aa /tests/DynamicCodeLoggerIntegrationTests/src/cpp/test_executable.cpp
parent5c9429661e8c0326242155757a4d22bcb52b0401 (diff)
Autofill: Fix unsafe usages of mCurrentViewId related to Inline UI.
With this change, the value is captured locally before being used in any lambdas related to inline suggestions. Otherwise, the lambda can be executed for a different view than intended, which can also cause an NPE if a VIEW_EXITED event occurs (see linked bug). This change also includes a null-check in requestShowInlineSuggestionsLocked. It's unclear if it's possible for the value to be null there, but the check is added to be safe. There are other usages of mCurrentViewId that should ideally be guarded by null-checks, but those shall be fixed separately (or refactored later). Test: manual - (1) add a Thread.sleep at line 3146, (2) tap on url bar to trigger Augmented request, (3) close keyboard to trigger the NPE. Test: atest InlineLoginActivityTest InlineAugmentedLoginActivityTest Fix: 153877905 Change-Id: Ibcf8f17417ec7a3fa854816783b63879c4d18669
Diffstat (limited to 'tests/DynamicCodeLoggerIntegrationTests/src/cpp/test_executable.cpp')
0 files changed, 0 insertions, 0 deletions