diff options
| author | Yohei Yukawa <yukawa@google.com> | 2018-12-28 17:23:29 -0800 |
|---|---|---|
| committer | Yohei Yukawa <yukawa@google.com> | 2018-12-28 17:23:29 -0800 |
| commit | 8a2b96bb0a1d901beb9cc9635c1fe9a265799b36 (patch) | |
| tree | d22070537d8d4605f3588d3841bcc7aed378045c /tests/DynamicCodeLoggerIntegrationTests/src/cpp/test_executable.cpp | |
| parent | 80c7a3f55fedea926c36b5e37317d8251b989c4d (diff) | |
Clarify shell/root users also have DUMP permission
This is a follow up CL to my previous CL [1], which aimed to
streamline and centralize when and how caller verifications are
performed inside InputMethodManagerService#onShellCommand().
The goal of this change is just to make it clear that shell/root users
also have DUMP permission. There should be no behavior change as long
as those users have DUMP permission because IMMS#onShellCommand() is
already locked down to accept IPCs only from these two UIDs [2].
The point is that ShellCommand#handleDefaultCommands() by default
dispatches 'dump' command to Binder#doDump() method. Thus it would
make sense to clarify that DUMP permission is also granted to
shell/root users for completeness.
[1]: I6fd47b5cc1e7da7222774df20247a2c69a70f45b
db25df71be4c1bcc654f69ce9a8bff7e3ef46360
[2]: If87189563ccaacd4f9c666bab4f9ad08a9343084
b8d240fa3f96b7b4ea35dd271beda789044d63ab
Bug: 34886274
Test: 'adb shell cmd input_method dump' still work
Change-Id: If91137e0c144d90ac3046f30607e36bb957a7e0e
Diffstat (limited to 'tests/DynamicCodeLoggerIntegrationTests/src/cpp/test_executable.cpp')
0 files changed, 0 insertions, 0 deletions