summaryrefslogtreecommitdiff
path: root/tests/DynamicCodeLoggerIntegrationTests/src/cpp/test_executable.cpp
diff options
context:
space:
mode:
authorJamie Garside <jgarside@google.com>2021-08-13 13:58:34 +0100
committerJamie Garside <jgarside@google.com>2021-08-13 13:54:15 +0000
commit6037800f125504e0e98eccd275d6b817227d37f3 (patch)
tree43554798131a2e4568427168589a990a01c63073 /tests/DynamicCodeLoggerIntegrationTests/src/cpp/test_executable.cpp
parenta44fcb0dd4fee683f1df0cb2fef4b1d3f9a917d8 (diff)
Ensure that the keyguard container is always below message area.
In the current layout, the keyguard container is simply added to the top-level NotificationShadeWindowView (descendant of FrameLayout) as a sibling of the message area, so there's no way to align anything underneath the message area (i.e. the "wrong PIN" bit). This is needed for future devices, as new UX specs have the PIN entry field (the four dots) immediately under the message area, rather than directly above the bouncer. Instead, this CL changes the keyguard inflation to inflate into a FrameLayout directly underneath the message area. LinearLayout weights are used to ensure it consumes all the remaining space. An alternative would be, of course, to move the message area into the keyguard views instead. This doesn't work, as the keyguard views are lazily inflated (even keyguard_bouncer.xml), and the message area is injected into some classes (via keyguard/dagger/KeyguardBouncerModule), and thus needs to be available before it has been added to the layout. It's probably fixable, but I really don't fancy rewriting half of the Dagger injection right now. Bug: 195012201 Test: Manually tested Change-Id: I5d909d8548c3ae31ade92935b143a6cdcab46700
Diffstat (limited to 'tests/DynamicCodeLoggerIntegrationTests/src/cpp/test_executable.cpp')
0 files changed, 0 insertions, 0 deletions