diff options
author | Rambo Wang <rambowang@google.com> | 2021-02-01 14:33:22 -0800 |
---|---|---|
committer | Rambo Wang <rambowang@google.com> | 2021-02-04 12:11:28 -0800 |
commit | 27be9449a5e1c93b8686b649513f3a21a2561548 (patch) | |
tree | dd18cab066c2286a74e7216c22ca410b44079beb /telephony/java/android | |
parent | ac598696b446148212781f508f2bdb977ae8d9ec (diff) |
Rename SignalThresholdInfo.Builder#setThresholdUnlimited
Use method overload instead of two distinguish names since they
are both used to set thresholds but for different callers.
Bug: 177956167
Test: atest com.android.internal.telephony.SignalThresholdInfoTest
Change-Id: I56cba06f8d70d87aa188c54d58fefa6d785f5054
Diffstat (limited to 'telephony/java/android')
-rw-r--r-- | telephony/java/android/telephony/SignalThresholdInfo.java | 24 |
1 files changed, 11 insertions, 13 deletions
diff --git a/telephony/java/android/telephony/SignalThresholdInfo.java b/telephony/java/android/telephony/SignalThresholdInfo.java index 0059ad6c2426..ae7d20929d58 100644 --- a/telephony/java/android/telephony/SignalThresholdInfo.java +++ b/telephony/java/android/telephony/SignalThresholdInfo.java @@ -402,29 +402,27 @@ public final class SignalThresholdInfo implements Parcelable { * @see #getThresholds() for more details on signal strength thresholds */ public @NonNull Builder setThresholds(@NonNull int[] thresholds) { - Objects.requireNonNull(thresholds, "thresholds must not be null"); - if (thresholds.length < MINIMUM_NUMBER_OF_THRESHOLDS_ALLOWED - || thresholds.length > MAXIMUM_NUMBER_OF_THRESHOLDS_ALLOWED) { - throw new IllegalArgumentException( - "thresholds length must between " + MINIMUM_NUMBER_OF_THRESHOLDS_ALLOWED - + " and " + MAXIMUM_NUMBER_OF_THRESHOLDS_ALLOWED); - } - mThresholds = thresholds.clone(); - Arrays.sort(mThresholds); - return this; + return setThresholds(thresholds, false /*isSystem*/); } /** - * Set the signal strength thresholds for the corresponding signal measurement type without - * the length limitation. + * Set the signal strength thresholds for the corresponding signal measurement type. * * @param thresholds array of integer as the signal threshold values + * @param isSystem true is the caller is system which does not have restrictions on + * the length of thresholds array. * @return the builder to facilitate the chaining * * @hide */ - public @NonNull Builder setThresholdsUnlimited(@NonNull int[] thresholds) { + public @NonNull Builder setThresholds(@NonNull int[] thresholds, boolean isSystem) { Objects.requireNonNull(thresholds, "thresholds must not be null"); + if (!isSystem && (thresholds.length < MINIMUM_NUMBER_OF_THRESHOLDS_ALLOWED + || thresholds.length > MAXIMUM_NUMBER_OF_THRESHOLDS_ALLOWED)) { + throw new IllegalArgumentException( + "thresholds length must between " + MINIMUM_NUMBER_OF_THRESHOLDS_ALLOWED + + " and " + MAXIMUM_NUMBER_OF_THRESHOLDS_ALLOWED); + } mThresholds = thresholds.clone(); Arrays.sort(mThresholds); return this; |