diff options
author | yawanng <yawanng@google.com> | 2020-07-14 23:58:07 +0000 |
---|---|---|
committer | yawanng <yawanng@google.com> | 2020-07-15 02:22:20 +0000 |
commit | ef5e1a6dbee8c7b2db4f150ea9463a8523a207ec (patch) | |
tree | a391d13e747e9f0d37b3c5d3f4ff14dc3a349961 /startop | |
parent | 68bdd1abae062caa02375c5cbb6ffe46302ddd78 (diff) |
EventSequenceValidator: Only record the debug log in debugging level.
The stack trace log may confuse other developers and mistakenly points
to IORap as the bug cause.
Bug: 161145462
Test: Make and check the logcat.
Change-Id: I3cb24cace060cff381ab3c5770ff6c1c948a2d89
Diffstat (limited to 'startop')
-rw-r--r-- | startop/iorap/src/com/google/android/startop/iorap/EventSequenceValidator.java | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/startop/iorap/src/com/google/android/startop/iorap/EventSequenceValidator.java b/startop/iorap/src/com/google/android/startop/iorap/EventSequenceValidator.java index 7e8a90ccd4ad..dcaff26b79c6 100644 --- a/startop/iorap/src/com/google/android/startop/iorap/EventSequenceValidator.java +++ b/startop/iorap/src/com/google/android/startop/iorap/EventSequenceValidator.java @@ -96,7 +96,8 @@ import java.io.PrintWriter; */ public class EventSequenceValidator implements ActivityMetricsLaunchObserver { static final String TAG = "EventSequenceValidator"; - + /** $> adb shell 'setprop log.tag.EventSequenceValidator VERBOSE' */ + public static final boolean DEBUG = Log.isLoggable(TAG, Log.DEBUG); private State state = State.INIT; private long accIntentStartedEvents = 0; @@ -255,10 +256,12 @@ public class EventSequenceValidator implements ActivityMetricsLaunchObserver { } private void logWarningWithStackTrace(String log) { - StringWriter sw = new StringWriter(); - PrintWriter pw = new PrintWriter(sw); - new Throwable("EventSequenceValidator#getStackTrace").printStackTrace(pw); - Log.wtf(TAG, String.format("%s\n%s", log, sw)); + if (DEBUG) { + StringWriter sw = new StringWriter(); + PrintWriter pw = new PrintWriter(sw); + new Throwable("EventSequenceValidator#getStackTrace").printStackTrace(pw); + Log.wtf(TAG, String.format("%s\n%s", log, sw)); + } } } |