summaryrefslogtreecommitdiff
path: root/startop/view_compiler/layout_validation.cc
diff options
context:
space:
mode:
authorEric Holk <eholk@google.com>2018-12-13 16:04:56 -0800
committerEric Holk <eholk@google.com>2018-12-14 09:36:14 -0800
commit3cbf176e7c6a96c535f56cb7d10e2de79a54cbd0 (patch)
tree405baf89c19d18830dfe7f8111d99ad219485667 /startop/view_compiler/layout_validation.cc
parent657d61220648e924b24973c62f984d8654f7bd1f (diff)
[view-compiler] Add layout validation
Layout validation walks over a layout resource and verifies that the layout only uses features the layout compiler supports. Currently this means we reject layouts that use any of the following tags: * include * fragment * merge * view In the future, we will extend the layout compiler to handle these, but for now we want to be liberal in what we reject. Bug: 111895153 Test: atest view-compiler-tests Change-Id: I8dca30c035a83b6763497a36fc60c68438fa1b0c
Diffstat (limited to 'startop/view_compiler/layout_validation.cc')
-rw-r--r--startop/view_compiler/layout_validation.cc42
1 files changed, 42 insertions, 0 deletions
diff --git a/startop/view_compiler/layout_validation.cc b/startop/view_compiler/layout_validation.cc
new file mode 100644
index 000000000000..8c7737749124
--- /dev/null
+++ b/startop/view_compiler/layout_validation.cc
@@ -0,0 +1,42 @@
+/*
+ * Copyright (C) 2018 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "layout_validation.h"
+
+#include "android-base/stringprintf.h"
+
+namespace startop {
+
+void LayoutValidationVisitor::VisitStartTag(const std::u16string& name) {
+ if (0 == name.compare(u"merge")) {
+ message_ = "Merge tags are not supported";
+ can_compile_ = false;
+ }
+ if (0 == name.compare(u"include")) {
+ message_ = "Include tags are not supported";
+ can_compile_ = false;
+ }
+ if (0 == name.compare(u"view")) {
+ message_ = "View tags are not supported";
+ can_compile_ = false;
+ }
+ if (0 == name.compare(u"fragment")) {
+ message_ = "Fragment tags are not supported";
+ can_compile_ = false;
+ }
+}
+
+} // namespace startop \ No newline at end of file