diff options
author | Treehugger Robot <treehugger-gerrit@google.com> | 2021-03-22 13:39:40 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2021-03-22 13:39:40 +0000 |
commit | 79ddf1afb8db511c3586e8dac932c711bb3c0f57 (patch) | |
tree | 6d7b40986a60f5944c26f51db4ad5f7be138928a /services | |
parent | 965d021bf5812c144ff3541d0609e26ee01e5804 (diff) | |
parent | 2b57c52b03911297772dd9cb8ce3180a8c25c56b (diff) |
Merge "Remove reference of getActiveLinkproperties"
Diffstat (limited to 'services')
-rw-r--r-- | services/core/java/com/android/server/VpnManagerService.java | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/services/core/java/com/android/server/VpnManagerService.java b/services/core/java/com/android/server/VpnManagerService.java index 56aabc208027..d756c1ffd00f 100644 --- a/services/core/java/com/android/server/VpnManagerService.java +++ b/services/core/java/com/android/server/VpnManagerService.java @@ -352,7 +352,10 @@ public class VpnManagerService extends IVpnManager.Stub { @Override public void startLegacyVpn(VpnProfile profile) { int user = UserHandle.getUserId(mDeps.getCallingUid()); - final LinkProperties egress = mCm.getActiveLinkProperties(); + // Note that if the caller is not system (uid >= Process.FIRST_APPLICATION_UID), + // the code might not work well since getActiveNetwork might return null if the uid is + // blocked by NetworkPolicyManagerService. + final LinkProperties egress = mCm.getLinkProperties(mCm.getActiveNetwork()); if (egress == null) { throw new IllegalStateException("Missing active network connection"); } |