summaryrefslogtreecommitdiff
path: root/services/people
diff options
context:
space:
mode:
authorTrung Lam <lamtrung@google.com>2020-02-27 11:30:45 -0800
committerTrung Lam <lamtrung@google.com>2020-02-27 15:04:06 -0800
commit2dcfcc1dee71f2e9808f40cf90e91712ebf44501 (patch)
tree721903fe887a8db42dd34110c4a3818a741b18f9 /services/people
parentb629d69db047c40f2b110f2d73ad8ceb1b32ea68 (diff)
Fix unit tests for people service.
Change-Id: I27f46b65055880f53fccc0e8a609c520fa0ef053 Test: Built and tested on device. Bug: 150242664
Diffstat (limited to 'services/people')
-rw-r--r--services/people/java/com/android/server/people/data/AggregateEventHistoryImpl.java8
-rw-r--r--services/people/java/com/android/server/people/data/ConversationStore.java5
-rw-r--r--services/people/java/com/android/server/people/data/EventIndex.java5
3 files changed, 11 insertions, 7 deletions
diff --git a/services/people/java/com/android/server/people/data/AggregateEventHistoryImpl.java b/services/people/java/com/android/server/people/data/AggregateEventHistoryImpl.java
index 4ac346b51b22..6abf6d256caf 100644
--- a/services/people/java/com/android/server/people/data/AggregateEventHistoryImpl.java
+++ b/services/people/java/com/android/server/people/data/AggregateEventHistoryImpl.java
@@ -42,14 +42,16 @@ class AggregateEventHistoryImpl implements EventHistory {
@NonNull
@Override
public EventIndex getEventIndex(Set<Integer> eventTypes) {
- EventIndex merged = new EventIndex();
+ EventIndex merged = null;
for (EventHistory eventHistory : mEventHistoryList) {
EventIndex eventIndex = eventHistory.getEventIndex(eventTypes);
- if (!eventIndex.isEmpty()) {
+ if (merged == null) {
+ merged = eventIndex;
+ } else if (!eventIndex.isEmpty()) {
merged = EventIndex.combine(merged, eventIndex);
}
}
- return merged;
+ return merged != null ? merged : EventIndex.EMPTY;
}
@NonNull
diff --git a/services/people/java/com/android/server/people/data/ConversationStore.java b/services/people/java/com/android/server/people/data/ConversationStore.java
index 89c4972c8ef4..63625eb4df61 100644
--- a/services/people/java/com/android/server/people/data/ConversationStore.java
+++ b/services/people/java/com/android/server/people/data/ConversationStore.java
@@ -192,7 +192,10 @@ class ConversationStore {
mLocusIdToShortcutIdMap.clear();
mNotifChannelIdToShortcutIdMap.clear();
mPhoneNumberToShortcutIdMap.clear();
- mConversationInfosProtoDiskReadWriter.deleteConversationsFile();
+ ConversationInfosProtoDiskReadWriter writer = getConversationInfosProtoDiskReadWriter();
+ if (writer != null) {
+ writer.deleteConversationsFile();
+ }
}
@MainThread
diff --git a/services/people/java/com/android/server/people/data/EventIndex.java b/services/people/java/com/android/server/people/data/EventIndex.java
index 47b620773180..6a13b0e6dd6e 100644
--- a/services/people/java/com/android/server/people/data/EventIndex.java
+++ b/services/people/java/com/android/server/people/data/EventIndex.java
@@ -129,8 +129,7 @@ public class EventIndex {
}
EventIndex(@NonNull EventIndex from) {
- this(from.mInjector, Arrays.copyOf(from.mEventBitmaps, TIME_SLOT_TYPES_COUNT),
- from.mLastUpdatedTime);
+ this(from.mInjector, from.mEventBitmaps, from.mLastUpdatedTime);
}
@VisibleForTesting
@@ -140,7 +139,7 @@ public class EventIndex {
private EventIndex(@NonNull Injector injector, long[] eventBitmaps, long lastUpdatedTime) {
mInjector = injector;
- mEventBitmaps = eventBitmaps;
+ mEventBitmaps = Arrays.copyOf(eventBitmaps, TIME_SLOT_TYPES_COUNT);
mLastUpdatedTime = lastUpdatedTime;
}