diff options
author | Chalard Jean <jchalard@google.com> | 2020-07-02 13:59:44 +0000 |
---|---|---|
committer | Remi NGUYEN VAN <reminv@google.com> | 2020-07-02 23:47:35 +0000 |
commit | a35580e0ddd07721a1eae3fdbca7e518ea68780c (patch) | |
tree | 49de84c12158c3124416a99f0868091aae205b3f /services/net/java | |
parent | 57d68e3c55176083ba40947be8f335534d958006 (diff) |
Revert "Move Inet[4]AddressUtils to libs/net"
This reverts commit 57d68e3c55176083ba40947be8f335534d958006.
Reason for revert: Breaks the build b/160390899
Merged-In: Icd141a992c46290c74929785e261a1cd57bc001b
Change-Id: Ie10e66f61393602f17fbb61bf17230b176bf1f44
Diffstat (limited to 'services/net/java')
-rw-r--r-- | services/net/java/android/net/ip/IpClientCallbacks.java | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/services/net/java/android/net/ip/IpClientCallbacks.java b/services/net/java/android/net/ip/IpClientCallbacks.java index b17fcaa132a1..b172c4be7b0d 100644 --- a/services/net/java/android/net/ip/IpClientCallbacks.java +++ b/services/net/java/android/net/ip/IpClientCallbacks.java @@ -68,13 +68,12 @@ public class IpClientCallbacks { */ public void onNewDhcpResults(DhcpResultsParcelable dhcpResults) { // In general callbacks would not use a parcelable directly (DhcpResultsParcelable), and - // would use a wrapper instead, because of the lack of safety of stable parcelables. But - // there are already two classes in the tree for DHCP information: DhcpInfo and DhcpResults, - // and neither of them exposes an appropriate API (they are bags of mutable fields and can't - // be changed because they are public API and @UnsupportedAppUsage, being no better than the - // stable parcelable). Adding a third class would cost more than the gain considering that - // the only client of this callback is WiFi, which will end up converting the results to - // DhcpInfo anyway. + // would use a wrapper instead. But there are already two classes in the tree for DHCP + // information: DhcpInfo and DhcpResults, and each of them do not expose an appropriate API + // (they are bags of mutable fields and can't be changed because they are public API and + // @UnsupportedAppUsage). Adding a third class would cost more than the gain considering + // that the only client of this callback is WiFi, which will end up converting the results + // to DhcpInfo anyway. } /** |