diff options
| author | Aaron Huang <huangaaron@google.com> | 2021-02-08 10:43:40 +0000 |
|---|---|---|
| committer | Aaron Huang <huangaaron@google.com> | 2021-03-10 23:19:12 +0800 |
| commit | b4cbcf01aa9cde6ab6fb0403cca7b02268b4cff9 (patch) | |
| tree | 902fc2660c770743fb5c53fa9cc42a96278017f3 /services/java/com/android/server/SystemServer.java | |
| parent | 643fb23a74a8382bfa73f8b517990dc20d356c87 (diff) | |
Revert^2 "Refactor setCurrentProxyScriptUrl to a void method"
setCurrentProxyScriptUrl is used by ProxyTracker which is
included in connectivity service mainline module. To make
this method @SystemApi in follow-up patch, change this
from a boolean method to a void method. Moving the send or
not send broadcast logic to caller because it can know
whether it needs to send a broadcast or not.
The original change was reverted because it broke DeviceOwnerTest
and HostsideVpnTests. The new patch fixes no broadcast sent bug.
The logic was reversed when a PAC file URL is empty so the
broadcast did not send when proxy change.
Bug: 179225084
Bug: 177035719
Test: FrameworksNetTests
CtsHostsideNetworkTests:HostsideVpnTests#testSetProxy
CtsHostsideNetworkTests:HostsideVpnTests#testBindToNetworkWithProxy
CtsHostsideNetworkTests:HostsideVpnTests#testNoProxy
CtsDevicePolicyManagerTestCases:DeviceOwnerTest#testProxyPacProxyTest
CtsDevicePolicyManagerTestCases:DeviceOwnerTest#testProxyStaticProxyTest
Change-Id: I029c33913264bfee336a559c4bd048ddd027322b
Diffstat (limited to 'services/java/com/android/server/SystemServer.java')
0 files changed, 0 insertions, 0 deletions