diff options
| author | Matthew Xie <mattx@google.com> | 2012-07-12 16:03:32 -0700 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2012-07-16 21:30:45 -0700 |
| commit | fe19f1234e460a22e43a53665db1c48613844fa6 (patch) | |
| tree | 43d2967d27df85f154d32c2c2af75cb15bc47584 /services/java/com/android/server/NetworkManagementService.java | |
| parent | 6fde3098074ab2551867d1cd919958383b15725f (diff) | |
Add TODO comments to remove start/stopReverseTethering
Change start/stopReverseTethering permission from CHANGE_NETWORK_STATE
to CONNECTIVITY_INTERNAL
Change-Id: Iac76d5af6418e6a3e2d2f77bf713466981285e1a
Diffstat (limited to 'services/java/com/android/server/NetworkManagementService.java')
| -rw-r--r-- | services/java/com/android/server/NetworkManagementService.java | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/services/java/com/android/server/NetworkManagementService.java b/services/java/com/android/server/NetworkManagementService.java index ccba0d24c6cf..648dfff5c546 100644 --- a/services/java/com/android/server/NetworkManagementService.java +++ b/services/java/com/android/server/NetworkManagementService.java @@ -780,11 +780,12 @@ public class NetworkManagementService extends INetworkManagementService.Stub event.checkCode(TetherStatusResult); return event.getMessage().endsWith("started"); } + + // TODO(BT) Remove public void startReverseTethering(String iface) throws IllegalStateException { if (DBG) Slog.d(TAG, "startReverseTethering in"); - mContext.enforceCallingOrSelfPermission( - android.Manifest.permission.CHANGE_NETWORK_STATE, "NetworkManagementService"); + mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG); // cmd is "tether start first_start first_stop second_start second_stop ..." // an odd number of addrs will fail String cmd = "tether start-reverse"; @@ -798,9 +799,10 @@ public class NetworkManagementService extends INetworkManagementService.Stub BluetoothTetheringDataTracker.getInstance().startReverseTether(iface); } + + // TODO(BT) Remove public void stopReverseTethering() throws IllegalStateException { - mContext.enforceCallingOrSelfPermission( - android.Manifest.permission.CHANGE_NETWORK_STATE, "NetworkManagementService"); + mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG); try { mConnector.doCommand("tether stop-reverse"); } catch (NativeDaemonConnectorException e) { |