summaryrefslogtreecommitdiff
path: root/services/incremental/test/IncrementalServiceTest.cpp
diff options
context:
space:
mode:
authorSongchun Fan <schfan@google.com>2021-05-27 19:15:48 -0700
committerSongchun Fan <schfan@google.com>2021-05-28 03:08:39 +0000
commit0d68016aea59d1de4e89f4f2d5c131bf55cd1e80 (patch)
treebef25ec307bd73e4664e1bf9f4c17a7cc25105a8 /services/incremental/test/IncrementalServiceTest.cpp
parent27008c112347ffcaa5ef2a70708ab1e2c77c4ef6 (diff)
[incremental/metrics] report uid of last read error
BUG: 187354818 Test: atest service.incremental_test Change-Id: I632b747440ed4faef31266a3a7b18b7a382ff2cf
Diffstat (limited to 'services/incremental/test/IncrementalServiceTest.cpp')
-rw-r--r--services/incremental/test/IncrementalServiceTest.cpp14
1 files changed, 12 insertions, 2 deletions
diff --git a/services/incremental/test/IncrementalServiceTest.cpp b/services/incremental/test/IncrementalServiceTest.cpp
index fae654edf6b4..094c5fb36eea 100644
--- a/services/incremental/test/IncrementalServiceTest.cpp
+++ b/services/incremental/test/IncrementalServiceTest.cpp
@@ -2260,6 +2260,11 @@ TEST_F(IncrementalServiceTest, testMetricsWithNoLastReadError) {
result.getInt(String16(BnIncrementalService::METRICS_LAST_READ_ERROR_NUMBER().c_str()),
&lastReadErrorNumber));
ASSERT_EQ(expectedLastReadErrorNumber, lastReadErrorNumber);
+ int expectedLastReadUid = -1, lastReadErrorUid = -1;
+ ASSERT_FALSE(
+ result.getInt(String16(BnIncrementalService::METRICS_LAST_READ_ERROR_UID().c_str()),
+ &lastReadErrorUid));
+ ASSERT_EQ(expectedLastReadUid, lastReadErrorUid);
}
TEST_F(IncrementalServiceTest, testMetricsWithLastReadError) {
@@ -2272,7 +2277,8 @@ TEST_F(IncrementalServiceTest, testMetricsWithLastReadError) {
duration_cast<std::chrono::microseconds>(
now.time_since_epoch())
.count()),
- .errorNo = static_cast<uint32_t>(-ETIME)}));
+ .errorNo = static_cast<uint32_t>(-ETIME),
+ .uid = 20000}));
TemporaryDir tempDir;
int storageId =
mIncrementalService->createStorage(tempDir.path, mDataLoaderParcel,
@@ -2283,7 +2289,7 @@ TEST_F(IncrementalServiceTest, testMetricsWithLastReadError) {
mClock->advanceMs(10);
android::os::PersistableBundle result{};
mIncrementalService->getMetrics(storageId, &result);
- ASSERT_EQ(11, (int)result.size());
+ ASSERT_EQ(12, (int)result.size());
int64_t expectedMillisSinceLastReadError = 10, millisSinceLastReadError = -1;
ASSERT_TRUE(result.getLong(String16(BnIncrementalService::METRICS_MILLIS_SINCE_LAST_READ_ERROR()
.c_str()),
@@ -2294,6 +2300,10 @@ TEST_F(IncrementalServiceTest, testMetricsWithLastReadError) {
result.getInt(String16(BnIncrementalService::METRICS_LAST_READ_ERROR_NUMBER().c_str()),
&lastReadErrorNumber));
ASSERT_EQ(expectedLastReadErrorNumber, lastReadErrorNumber);
+ int expectedLastReadUid = 20000, lastReadErrorUid = -1;
+ ASSERT_TRUE(result.getInt(String16(BnIncrementalService::METRICS_LAST_READ_ERROR_UID().c_str()),
+ &lastReadErrorUid));
+ ASSERT_EQ(expectedLastReadUid, lastReadErrorUid);
}
} // namespace android::os::incremental