summaryrefslogtreecommitdiff
path: root/rs
diff options
context:
space:
mode:
authorYang Ni <yangni@google.com>2017-04-28 08:45:40 -0700
committerYang Ni <yangni@google.com>2017-06-13 19:41:55 +0000
commit3a84a23f36f85f5a16503d3d220358175582f83b (patch)
tree153265cd3512080df3af60a0a0d42e6ef2a293e0 /rs
parentf02b7b7ba6a712a0803877907b8d4ed30ace169d (diff)
Do not CloseGuard KernelID or FieldID
Bug: 28053584 Stop CloseGuarding for two reasons: 1) KernelID and FieldID objects are constructed in auto-generated (RenderScript reflected) Java code. It would be impossible for a user to explicitly call destroy() on them. Guarding them would leave a lot of noisy warnings in logcat. 2) These KernelID and FieldID objects are not big compared to other RenderScript objects, e.g. Allocations. They occupy almost no native resources except for a native pointer. Leaving their destruction to Java GC would be completely acceptable, since any delay in reclaiming them is unlikely to cause memory pressure. Test: CTS on x86_64 emulator Change-Id: I587b5561a0b2bdbf0b2e95bf2995c20d5f5faf9d
Diffstat (limited to 'rs')
-rw-r--r--rs/java/android/renderscript/Script.java2
1 files changed, 0 insertions, 2 deletions
diff --git a/rs/java/android/renderscript/Script.java b/rs/java/android/renderscript/Script.java
index 13d5fcd57446..d0d9a114bbae 100644
--- a/rs/java/android/renderscript/Script.java
+++ b/rs/java/android/renderscript/Script.java
@@ -41,7 +41,6 @@ public class Script extends BaseObj {
mScript = s;
mSlot = slot;
mSig = sig;
- guard.open("destroy");
}
}
@@ -119,7 +118,6 @@ public class Script extends BaseObj {
super(id, rs);
mScript = s;
mSlot = slot;
- guard.open("destroy");
}
}