diff options
| author | Mike Wallstedt <mikewallstedt@google.com> | 2019-12-12 15:54:56 -0800 |
|---|---|---|
| committer | Mike Wallstedt <mikewallstedt@google.com> | 2019-12-12 16:19:09 -0800 |
| commit | 6d11ca44232ecce767dfd193b91c33206899f80f (patch) | |
| tree | 0c57614ebaf537078364f2f8963164f2001a06de /rs/java/android/renderscript/RenderScriptGL.java | |
| parent | 3ebefd8e8b366444325437fb6c450dd40768a6eb (diff) | |
Avoid ambiguous overloads in SpannableStringInternal.
As documented in Effective Java (http://go/ej3e#page=259), overloaded
methods with the same number of parameters can be confusing when the
parameters are in the same type hierarchy.
Aside from readability concerns, this may be related to some crashes
observed in Photos Android. For example in b/144849105 AutoCompleteViewBinder
calls the SpannedString constructor, which delegates to SpannedStringInternal.
The overload of copySpans that accepts a SpannedStringInternal has a call to
isOutOfCopyRange that should make the failure in checkRange impossible.
Bug: 144849105
Test: Simple refactor.
Change-Id: I47d01cffe6f66c4d631a9ef1341bf118fb6e51e4
Diffstat (limited to 'rs/java/android/renderscript/RenderScriptGL.java')
0 files changed, 0 insertions, 0 deletions