diff options
| author | Nader Jawad <njawad@google.com> | 2019-03-28 17:28:00 -0700 |
|---|---|---|
| committer | android-build-team Robot <android-build-team-robot@google.com> | 2019-04-01 19:15:25 +0000 |
| commit | f273f8db2fd7f4758ca886297467fd3fd1011e07 (patch) | |
| tree | aea33cc4ef18cf942a545fe6fc4a53038104c3e1 /rs/java/android/renderscript/RenderScript.java | |
| parent | 157946217ed576890a8958ef322ee31797c4695c (diff) | |
Relaxed nullability requirements for setTintMode APIs for
both PorterDuff.Mode and BlendMode
The existing documentation had annotated the PorterDuff.Mode
parameter of Drawable#setTintMode to be @NonNull. However,
some applications were still passing in null as a parameter.
This was fine in previous releases as the default implementation
of Drawable#setTintMode did not read this field. With the
recent changes to introduce the BlendMode API, the nullability
assumption broke for various apps that passed in null, causing
NullPointerExceptions to be thrown.
Instead, update the documentation to be nullable and internally
convert the parameter to the corresponding default for either
PorterDuff.Mode or BlendMode.
Test: Added CTS tests to verify null behavior for each setTintMode
overload
Bug: 129446670
Change-Id: I42a4b03d190e5a64df518b5c768b2c22853abf12
(cherry picked from commit 7ddb3965d949e53def927fc926f77850bf85d29e)
Diffstat (limited to 'rs/java/android/renderscript/RenderScript.java')
0 files changed, 0 insertions, 0 deletions