diff options
| author | Raph Levien <raph@google.com> | 2014-06-15 18:25:29 -0700 |
|---|---|---|
| committer | Raph Levien <raph@google.com> | 2014-06-16 14:36:08 -0700 |
| commit | 051910b9f998030dacb8a0722588cc715813fde1 (patch) | |
| tree | 965db8624bf9d796306a22f9870315028ef22992 /rs/java/android/renderscript/ProgramVertexFixedFunction.java | |
| parent | 5d140e4b1b1d43c742a7d67dd5f9d394c846945f (diff) | |
Clean up dirFlags / bidiFlags confusion
The dirFlags and bidiFlags enums are distinct, and have different
meanings. The former is a determined direction for a run of text, while
the latter is a request for the bidi algorithm. They have been used
interchangeably, and this has caused some problems, notably running the
bidi algorithm needlessly when the direction for a run is already
determined.
This patch cleans up the confusion, by always naming each occurrence
explicitly "boolean isRtl" or "int bidiFlags" (the previous code often
just used "int flags", which added to the confusion), and converts
between the meanings when a function takes an isRtl argument but passes
it to another function expecting bidiFlags.
Fixes b/15089607 Clean up bidi flag mess
Change-Id: I410b6604376e853dd12c255e7f5a9d2b9a310dd9
Diffstat (limited to 'rs/java/android/renderscript/ProgramVertexFixedFunction.java')
0 files changed, 0 insertions, 0 deletions