diff options
| author | Yohei Yukawa <yukawa@google.com> | 2017-08-31 15:49:15 -0700 |
|---|---|---|
| committer | Yohei Yukawa <yukawa@google.com> | 2017-08-31 15:49:15 -0700 |
| commit | 98cf03348ecfbb549b8a51059f9f8688c8c08cbe (patch) | |
| tree | 1f517ef6a7dc698d270196a9423bf05e25e698a0 /rs/java/android/renderscript/ProgramStore.java | |
| parent | 01b6ff01781a7c818cc5b81d0b21fa2d21885434 (diff) | |
Print correct timeout messages in JobServiceContext
This is a follow up CL to a previous CL [1] that added some useful
debug messages to diagnose issues like Bug 62390590 and another
follow up CL [2] that aimed to address Bug 62787070.
What went wrong is that
"x" + y != null ? y.toShortString() : "<null>" + "z"
is interpretted as
("x" + y) != null ? y.toShortString() : ("<null>" + "z")
while what we wanted to see was
"x" + (y != null ? y.toShortString() : "<null>") + "z"
This CL addresses the above unexpected string concatenation by
explicitly having a private utility method
JobServiceContext#getRunningJobNameLocked().
[1]: Ia7155248b4b4f032cbf8e8754c5437f658ed192c
729a328aca436d71b80f3d72f5d54e38d4d2c12e
[2]: I7bc55f55da645a9e116d3f0ee02f2ee115383ea9
62292daa208d007a8c57b073303e8bb6169a2016
Bug: 62787070
Bug: 64569041
Bug: 65188019
Test: Manually verified by explicitly causing timeout.
Change-Id: I3e51f40d3fcf0e2ddd200da2812aba109d89794e
Diffstat (limited to 'rs/java/android/renderscript/ProgramStore.java')
0 files changed, 0 insertions, 0 deletions