summaryrefslogtreecommitdiff
path: root/rs/java/android/renderscript/ProgramStore.java
diff options
context:
space:
mode:
authorTobias Thierer <tobiast@google.com>2020-09-29 23:22:20 +0100
committerTobias Thierer <tobiast@google.com>2020-09-30 00:13:32 +0100
commit61d2bbef5e4b12a7a72ab22fc463e411258455f8 (patch)
tree7b7dea10d5f30777a321d4829283d4eee8230047 /rs/java/android/renderscript/ProgramStore.java
parent3fb439536cd291794a28d1c6458b4799bb8a0cf2 (diff)
DataChangedJournal: Make nonfinal to partially fix a test breakage.
Context: KeyValueBackupTask's ctor takes a DataChangedJournal instance. KeyValueBackupTaskTest uses a mock instance to check that remove() is called. http://ag/12218310 made DataChangedJournal final, breaking the test. This CL fixes the failure cause by making the class nonfinal. Note that the test still fails because at least one unrelated failure cause remains - see http://b/162022005#comment11 In the longer term, we may want to consider splitting DataChangedJournal into an interface/abstract class + a concrete implementation; there's no good reason why KeyValueBackupTask and KeyValueBackupReporter need to depend on specifically the implementation class, when all they're calling is remove() and toString(). However, the change to make the class final wasn't important, and reverting it is the easiest / fasted way to unbreak the test. Bug: 162022005 Test: atest KeyValueBackupTaskTest Change-Id: I22b2a5d65f03c4ccdcc718ed3866d37ba9441385
Diffstat (limited to 'rs/java/android/renderscript/ProgramStore.java')
0 files changed, 0 insertions, 0 deletions