summaryrefslogtreecommitdiff
path: root/rs/java/android/renderscript/ProgramStore.java
diff options
context:
space:
mode:
authorQasid Ahmad Sadiq <qasid@google.com>2019-02-21 21:06:22 -0800
committerQasid Ahmad Sadiq <qasid@google.com>2019-02-21 21:07:12 -0800
commit4d70022b8841a17850dcb9d670f23b3ab6f3bb93 (patch)
tree4c415ddf91b607a744169e309ff9112b03974c31 /rs/java/android/renderscript/ProgramStore.java
parentec9d9834aa4ffab5582f7f87d680a2cec7409bdd (diff)
Revert "Fix a11y cache correctness bug"
This fix introduced a painful crash that ends up disabling accessibility services for certain users. This happens when a client of AccessibilityCache tries to add a node, with the same id as a node previously in the cache, but fewer children, where the removed child is not in the cache. This is because, when children are removed, and a the node is updated, the cache tries to clear the child trees. But if the child is not in the cache, the cache clears the whole tree. Every node is recycled. Then the original node being replaced is attempted to be recycled again, and voila crash. The fix also didn't fix the original issue based on the discussion in b/114133438. The risk for this is pretty low, since nothing was built on top of this. This reverts commit 2f69c16c3dd0ea9522deebd9141ccc189b4a118e. Bug: 124676705 Test: Tested to see if above usecase still happens. Change-Id: I8a39698c4532a1613ba47e1c6ca70201cd496212
Diffstat (limited to 'rs/java/android/renderscript/ProgramStore.java')
0 files changed, 0 insertions, 0 deletions