diff options
| author | Yohei Yukawa <yukawa@google.com> | 2018-10-17 10:33:48 +0800 |
|---|---|---|
| committer | Yohei Yukawa <yukawa@google.com> | 2018-10-17 10:33:48 +0800 |
| commit | 0deaef032b0cf257152fa0b484f2521d2d672735 (patch) | |
| tree | 56106dbc139ee92fbbf605646b4a8ff3c135c6ae /rs/java/android/renderscript/ProgramStore.java | |
| parent | caaa1d3d2d3248dcc1ad1ea4c65d5a8949fb4219 (diff) | |
Polish InputMethodManagerService#startInputUncheckedLocked()
This CL aims to simplify logic recently added to IMMS to support
multiple displays (Bug 111364446).
With my previous CLs [1][2], now we can simply review what
InputMethodManagerService#startInputUncheckedLocked() is actually
doing. Things we found and this CL does address are:
1. Redundant if conditions against null IMMS#mCurMethodId.
2. Timing to check IMMS#mSystemReady.
3. Timing to check display id access
4. Timing to update IMMS#mCurTokenDisplayId.
5. Unnecessary complexity due to IMMS#mCurFocusedWindowClient, which
is now guaranteed to equal to |cs| in that method.
Although this CL is not a mechanical safe refactroing, the new
behavior should be more efficient, solid and easier to maintain.
[1]: I52f6c4cd1e02be3a59e9a87e33b0a44f4ba8d80b
f91a2b102b4bd28036e7f31f5888f6f4629d9d70
[2]: I71e259fa447dd06ff02b9ef8c958dc70bbce86ea
caaa1d3d2d3248dcc1ad1ea4c65d5a8949fb4219
Bug: 117730713
Test: atest ActivityManagerMultiDisplayTests
Test: atest CtsInputMethodTestCases CtsInputMethodServiceHostTestCases
Test: atest FrameworksCoreTests:android.view.inputmethod.InputMethodManagerTest
Change-Id: Ic9232d9c3ec9802101df5f0bc511c55465b5bbe6
Diffstat (limited to 'rs/java/android/renderscript/ProgramStore.java')
0 files changed, 0 insertions, 0 deletions