diff options
| author | Jay Thomas Sullivan <jaysullivan@google.com> | 2021-05-16 18:28:17 -0400 |
|---|---|---|
| committer | Jay Thomas Sullivan <jaysullivan@google.com> | 2021-05-17 12:30:31 -0400 |
| commit | ce7a059778e393d3fc3af8c02826d39958e835ae (patch) | |
| tree | 0710a2e6e298cd0b84edd265f1c253356b4c13f9 /rs/java/android/renderscript/ProgramFragmentFixedFunction.java | |
| parent | 63a1453832f1023c65dee59b7075949810a086c1 (diff) | |
Fix intermittent async noteOps
This removes the 'sThreadsListeningForOpNotedInBinderTransaction'
variable and its usages.
I think the intention of this variable was to act as a bloom filter:
i.e., "threadId is possibly in set or definitely not in set", but...
it's actually only giving us "threadId is possibly in set or possibly
not in set". This leads to false negatives, which leads to incorrect
behavior.
In this case, the incorrect behavior was that noteOps would sporatically
turn into async noteOps. This is currently causing a few tests to be
flaky: when setting a setOnOpNotedCallback listener, sometimes noteOps
code come back sync, sometimes async, and sometimes they get lost in transit.
Bug: 187722787
Test: atest --iterations=100 AppOpsLoggingTest#getBTScanResults
Change-Id: I26c7b8029ea140d850aba7ec77c691ed9fea76d9
Diffstat (limited to 'rs/java/android/renderscript/ProgramFragmentFixedFunction.java')
0 files changed, 0 insertions, 0 deletions