diff options
| author | Abodunrinwa Toki <toki@google.com> | 2020-11-17 15:52:35 +0000 |
|---|---|---|
| committer | Abodunrinwa Toki <toki@google.com> | 2020-11-19 13:49:09 +0000 |
| commit | c132a228736378af8cb2f5cb4f2002f02ce91502 (patch) | |
| tree | cbf3f59dbb8de91b613177e4f76e5f6f4eb36ed1 /rs/java/android/renderscript/ProgramFragmentFixedFunction.java | |
| parent | d9e62672d06cbb3debeb06260689c75cb2019694 (diff) | |
Ensure the toolbar refreshes its PendingIntents when it changes.
A bug in FloatingToolbar.isCurrentlyShowing(menuItems) caused the
toolbar not to update the menu item action in certain cases where the
text selection changed but the toolbar menu items did not change.
e.g. Fires a Translate PendingIntent with the wrong text selection.
This CL fixes that.
isCurrentlyShowing(menuItems) aims to help avoid the re-building of
toolbar views when unnecessary. This fix still maintains this idea
but ensures that the menuItem references are updated so that the
correct click listener is triggered when the menu item button is
clicked.
Bug: 150973392
Test: Manually tested. See bug for how to reproduce.
Test: atest android.widget.TextViewActivityTest
Test: atest android.view.textclassifier.cts.TextViewIntegrationTest
Test: atest android.widget.cts.TextViewTest
Change-Id: Iefedf40e1ea6f9499401918ab34d3ebac53fc385
Diffstat (limited to 'rs/java/android/renderscript/ProgramFragmentFixedFunction.java')
0 files changed, 0 insertions, 0 deletions