diff options
| author | James O'Leary <jamesoleary@google.com> | 2019-07-09 12:43:45 -0400 |
|---|---|---|
| committer | James O'Leary <jamesoleary@google.com> | 2019-07-22 15:30:04 +0000 |
| commit | 7b92b12342aeb33db5e78a79058e49080fabe1ae (patch) | |
| tree | 557ffd25118fc01ebdd2eab1fee4ccd8ec09be29 /rs/java/android/renderscript/ProgramFragmentFixedFunction.java | |
| parent | 6de7a3a3dd643f88c4d1ca6d01b87365cc3915a6 (diff) | |
Don't tell Assistant to hide on gesture completion or cancel
hide() is called by DefaultUiController itself when a gesture
fails to complete, or when the gesture animation finishes. (see
DefaultUiController.animateInvocationCompletion() and progress == 0
branch in DefaultUiController.onInvocationProgress())
hide() calls AssistManager.hideAssist(), which ultimately calls
VoiceInteractionSession#onCloseSystemDialogs(). We don't intend to
ask the assist app to close its UI when the gesture completes or when
invocation progress == 0.
Specifically, NgaUiController.hide /does not/ actually hide the
assistant (just our UI), and therefore
[DefaultUiController|GoogleDefaultUiController] shouldn't either. There
are times where NgaUiController does tell the assistant to close,
but they're specific to the NGA UI (e.g. there was a tap outside).
Bug: 136153254
Test: Verify WAI
Change-Id: I1cb9cb28a1009808e22571b2658f50f57b3e25b4
Diffstat (limited to 'rs/java/android/renderscript/ProgramFragmentFixedFunction.java')
0 files changed, 0 insertions, 0 deletions