summaryrefslogtreecommitdiff
path: root/rs/java/android/renderscript/ProgramFragmentFixedFunction.java
diff options
context:
space:
mode:
authorJoanne Chung <joannechung@google.com>2021-10-07 13:10:27 +0800
committerJoanne Chung <joannechung@google.com>2021-10-07 06:04:06 +0000
commit5667540a7d373ed7d0481e976a2738b10214e898 (patch)
treec7662f85f4c858e715651cd8712d124f4b4a821e /rs/java/android/renderscript/ProgramFragmentFixedFunction.java
parent395f43dd6f7e9dbdf0e756bfdefdb2358f580b1a (diff)
Fix not show translation if call startTranslation after pauseTranslation
It is possible the developer calls pauseTranslation() to show the original text but it calls startTranslation() to show translated text. Ideally the developer should call resumeTranslation but it also make sense to call startTranslation() to show translated text. When receiving translation response, we avoid showing transaltion if the view already has the response and it's the same. But it is good to also check if the view is showing translated text or not. If the view is not translated text, it is possible developer calls startTranslation() instead if calling pauseTranslation() to show translated again, the fixing can resolve this case. The issue case can be fixed by this change. But there is a deeper problem about it's useless the caller call finishTranslation(). This is planned to be fixed in next release. Bug: 201238016 Test: manual. The issue case is fixed. Test: manual. Test some chat apps, it still works fine. Test: atest CtsTranslationTestCases Change-Id: I699d0fa1d60ac96db094adcc6e17f4203df03214
Diffstat (limited to 'rs/java/android/renderscript/ProgramFragmentFixedFunction.java')
0 files changed, 0 insertions, 0 deletions